Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add action to collate fastp reports #1

Merged
merged 12 commits into from
Feb 13, 2025
Merged

ENH: add action to collate fastp reports #1

merged 12 commits into from
Feb 13, 2025

Conversation

misialq
Copy link
Contributor

@misialq misialq commented Feb 12, 2025

This PR:

  • adds a new collate-fastp-reports action for combining the reports generated by fastp
  • adds missing unit tests
  • migrates the project to using pyproject.toml

@misialq misialq requested a review from Copilot February 12, 2025 15:48

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 20 out of 33 changed files in this pull request and generated no comments.

Files not reviewed (13)
  • .coveragerc: Language not supported
  • .gitattributes: Language not supported
  • .github/workflows/q2-ci.yaml: Language not supported
  • MANIFEST.in: Language not supported
  • Makefile: Language not supported
  • setup.cfg: Language not supported
  • setup.py: Evaluated as low risk
  • q2_fastp/plugin_setup.py: Evaluated as low risk
  • conda-recipe/meta.yaml: Evaluated as low risk
  • q2_fastp/init.py: Evaluated as low risk
  • q2_fastp/tests/test_fastp.py: Evaluated as low risk
  • q2_fastp/utils.py: Evaluated as low risk
  • .github/workflows/ci-dev.yaml: Evaluated as low risk
Comments suppressed due to low confidence (1)

q2_fastp/tests/test_utils.py:30

  • Add a test case to check the behavior of 'collate_fastp_reports' when the 'reports' argument is empty.
def test_collate(self, p):
@misialq misialq requested a review from VinzentRisch February 13, 2025 09:40
Copy link

codecov bot commented Feb 13, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link

@VinzentRisch VinzentRisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey everything looks good to me.

@misialq misialq merged commit 33780ad into main Feb 13, 2025
10 checks passed
@misialq misialq deleted the collate-reports branch February 13, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants